Address warnings #10372
Merged
Address warnings #10372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tk0miya thanks for the review, updated. A |
|
Oops. conflicted. Could you update this, please? Then I'll merge this soon. |
# Conflicts: # tests/test_search.py
|
@tk0miya merged A |
tk0miya
approved these changes
May 2, 2022
| { | ||
| '__version_info__': docutils.__version_info__, | ||
| }, | ||
| RemovedInSphinx60Warning, |
There was a problem hiding this comment.
We're not in hurry. So I'll remove this in 7.0. I'll change this after merging.
There was a problem hiding this comment.
Oops, I meant to change that, sorry.
A
|
Thank you for your great work! Merging. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in #9777 (comment), there are some new warnings from Docutils.
This PR resolves warnings in
docutils.frontend.OptionParser,docutils.frontend.Option,docutils.nodes.Text, andsphinx.util.i18n.format_date.It switches to
image_loadingwith a fallback for Docutils 0.17 and earlier, and updates a few remaining cases ofNode.traverse->Node.findall.We also resolve all the EncodingWarnings from Sphinx directly (ones from Pytest or Docutils are not covered).
A
Feature or Bugfix