-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pass-through of sphinx-build CLI arguments to make.bat.new_t #6323
Comments
|
Yes, I know of On Linux, |
Thank you for explanation. I understand your goal. But, personally, I feel a bit strange for giving parameters for sphinx-build as arguments of make.bat. I know windows is not under UNIX culture. But... Note: I'm okay to add |
Ahh, I hadn't thought of it from that angle -- yeah, I can open a PR to add the |
@bskinn I think |
The make.bat.new_t template now passes %O% as well as %SPHINXOPTS% to `sphinx-build`, in parity with Makefile.new_t. The sphinx-build documentation page was updated to explicitly note $(O) and %O% as shortcut variables. Closes sphinx-doc#6323, per the comment thread discussion.
The make.bat_t and make.bat.new_t templates now pass %O% as well as %SPHINXOPTS% to `sphinx-build`, in parity with Makefile.new_t. The sphinx-build documentation page was updated to explicitly note $(O) and %O% as shortcut variables. Closes sphinx-doc#6323, per the comment thread discussion.
Is your feature request related to a problem? Please describe.
It's frustrating not being able to pass extra arguments to
make.bat
that then get provided tosphinx-build
. E.g.,> make html -Ean
is not feasible. (This is a subset of #3741.)Describe the solution you'd like
I'd like this capability to be added to Sphinx. I already have an implementation in my fork.
Describe alternatives you've considered
#3841 attempted a more-ambitious implementation, but was rejected due to likely too-great maintenance requirements. It looks like the whole makefile/make.bat setup will be obsoleted by #5618; but this seems like a simple enhancement to implement in the meantime.
Additional context
Screencap of implemented feature in action:
The text was updated successfully, but these errors were encountered: