-
-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new shield_list customization option #99
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Nice, thanks! Related / possibly subsumed in this: #13, #52. Minor nitpicks:
Also wondered if we could roll the GH button into this too, but it seems to use different HTML so meh, no big deal. (GH also has other options as well, so, it's special.) |
I agree.
Yep; I didn't want to passive-aggressively suggest that |
@bitprophet I changed the example to something that actually exists. |
also provide a suggested shield provider
This is almost identical to #124 . The only difference is that #124 uses a different option name ( @bitprophet I recommend going with either this or #124 and closing the other. |
I originally just wanted support for a circleci button, then I realized this could be made much more generic.
This adds support for including arbitrary shields in the about section.
Usage: