Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow description to be optional #120

Merged
merged 1 commit into from
Dec 6, 2022

Conversation

flxdot
Copy link

@flxdot flxdot commented Oct 8, 2021

I encountered this problem during the usage of this library in a project of mine. One endpoint was missing a description, which resulted in an build error.

This Pullrequest allows descriptions of any sort to be missing from the openapi.json.

The Specification it self does not require those fields (see https://swagger.io/specification/), thus this library should not force the user to provide it.

I would greatly appreciate, if this proposal makes it way into the next release.

@flxdot flxdot marked this pull request as ready for review October 8, 2021 09:01
@flxdot flxdot force-pushed the optional-description branch from 763be1f to 11356b2 Compare November 4, 2021 07:42
@stephenfin stephenfin force-pushed the optional-description branch from 11356b2 to 82a458d Compare December 6, 2022 17:27
@stephenfin stephenfin merged commit 1f06ad8 into sphinx-contrib:master Dec 6, 2022
@tuffnatty
Copy link
Contributor

tuffnatty commented Dec 11, 2022

Both in OpenAPI spec 2.0 and 3.0, description is a Required field on Response object, so I don't think this patch is fully correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants