Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated tag content to match new GA instructions #4

Merged
merged 1 commit into from
Aug 9, 2022

Conversation

OlivierCodol
Copy link
Contributor

The current instructions from the Google Analytics website are to use the following tag:

<!-- Google tag (gtag.js) -->
<script async src="https://www.googletagmanager.com/gtag/js?id=GA_ID_HERE"></script>
<script>
  window.dataLayer = window.dataLayer || [];
  function gtag(){dataLayer.push(arguments);}
  gtag('js', new Date());

  gtag('config', 'GA_ID_HERE');
</script>

With GA_ID_HERE the website ID provided by google analytics.

This amends the current function that adds the tag to each webpage to include this tag instead of the previous tag, which was not working on the website instances I tested it with.

@jelmer jelmer merged commit 42b3df9 into sphinx-contrib:master Aug 9, 2022
@jelmer jelmer mentioned this pull request Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants