Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RSS feed generation to use correct image sources #51

Conversation

sphars
Copy link
Owner

@sphars sphars commented May 6, 2024

Figured out that RSS feed generation will not be able to use the references to the image transform plugin since the plugin works after everything else is generated. See my comment here: 11ty/eleventy#3294. So now I'll use the markdown-it-eleventy-img plugin, which is a lot simpler and less troublesome.

Also fixes a number of issues:

  • fixes the Tried to use templateContent too early on <markdown file> (via TemplateContentPrematureUseError) error when serving the site and updating a markdown file (I think it was due to eleventy v3, which is why it's in alpha).
  • fixes issue with compiled css being overwritten with the non-compiled css
  • adjust which passthroughcopy options are made
  • Other general code cleanup

@sphars sphars linked an issue May 6, 2024 that may be closed by this pull request
- Remove the eleventy image transform plugin
- Use markdown eleventy-img plugin
- Fix issue with css getting overwritten with og css file on changes
- Change passthrough copy options to not copy unoptimized images
- Revert back to stable eleventy and eleventy-img packages to fix template render error on changes (and not needed for tranform plugin)
- Remove eleventyImport options in templates (I don't think it did anything)
- Code cleanup and removal of unnecessary files
Copy link

cloudflare-workers-and-pages bot commented May 9, 2024

Deploying spencerharston-com with  Cloudflare Pages  Cloudflare Pages

Latest commit: 71ea934
Status: ✅  Deploy successful!
Preview URL: https://c1d9169e.spencerharston-com.pages.dev
Branch Preview URL: https://50-investigate-rss-feed-temp.spencerharston-com.pages.dev

View logs

@sphars sphars marked this pull request as ready for review May 9, 2024 06:02
@sphars sphars merged commit b5ce5d2 into main May 9, 2024
1 check passed
@sphars sphars deleted the 50-investigate-rss-feed-template-using-incorrect-links-to-post-images branch May 10, 2024 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate RSS feed template using incorrect links to post images
1 participant