Implementation of S3M's Handlers Analysis #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
rafaelmotaalves
approved these changes
Jun 1, 2020
|
Posso integrar @barbosamaatheus @pauloborba ? |
|
por mim, sim. só verifica se não vai ter impacto no resto. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR referring to the integration of PD #70 into the new MiningFramework structure and organization.
My changes consist of:
Move the changes from PR Implementation of S3M's Handlers Analysis #70 to the new mining framework structure.
Correct the imports of the old code.
add Multibinder to projectProcessor and outputProcessor.
A problem has been identified in the recursive method
getBuildAttribute()of classsrc/main/services/util/BuildRequester.groovy. I added a comment for that.I ran the module StaticAnalysisConflictsDetectionModule on the master branch and on the branch with the integration. The results were the same. See: https://www.diffchecker.com/tWRn9PHU