Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a new line before package name and block comment #1099

Closed
wants to merge 1 commit into from

Conversation

mrasong
Copy link

@mrasong mrasong commented Apr 21, 2020

go-lint gives a warning when the block comment without a new line of package name.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Collaborator

@jharshman jharshman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mrasong CI is failing because your change caused the templates to no longer match the golden files.

@github-actions
Copy link

github-actions bot commented Jul 8, 2020

This PR is being marked as stale due to a long period of inactivity

@umarcor
Copy link
Contributor

umarcor commented Jul 8, 2020

Ref #1044.

@jharshman
Copy link
Collaborator

CI not passing. Closing as stale.

@jharshman jharshman closed this Dec 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants