Command aliases are not tab-completed

[Airblader]

Say you have some command

	cmd := &cobra.Command{
		Use:                   "context",
		Aliases:               []string{"ctx"},
	}

Then completing ct will not work:

prog __complete ct

:4
Completion ended with directive: ShellCompDirectiveNoFileComp

I think the issue is this, though I have not debugged into it, it's just by reading the code:

			// Complete subcommand names, including the help command
			if len(finalArgs) == 0 && !foundLocalNonPersistentFlag {
				// We only complete sub-commands if:
				// - there are no arguments on the command-line and
				// - there are no local, non-persistent flags on the command-line or TraverseChildren is true
				for _, subCmd := range finalCmd.Commands() {
					if subCmd.IsAvailableCommand() || subCmd == finalCmd.helpCommand {
						if strings.HasPrefix(subCmd.Name(), toComplete) {
							completions = append(completions, fmt.Sprintf("%s\t%s", subCmd.Name(), subCmd.Short))
						}
						directive = ShellCompDirectiveNoFileComp
					}
				}
			}

This code path does not take the command's aliases into account.

This appears to be a duplicate of #1296, which has been closed with a reference to some discussion that seems inconclusive to me. I can't think of any reason not to tab-complete aliases, because they are most useful in interactive sessions, i.e., exactly in the situations where a user would want tab-completions to work.

[github-actions]

The Cobra project currently lacks enough contributors to adequately respond to all issues. This bot triages issues and PRs according to the following rules:

• After 60d of inactivity, lifecycle/stale is applied. - After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied and the issue is closed.
  You can:
• Make a comment to remove the stale label and show your support. The 60 days reset. - If an issue has lifecycle/rotten and is closed, comment and ask maintainers if they'd be interested in reopening

[bartekpacia]

I can't think of any reason not to tab-complete aliases, because they are most useful in interactive sessions, i.e., exactly in the situations where a user would want tab-completions to work.

I strongly disagree with this. I don't want completion to highlight aliases and shortcuts.

If this change is ever considered, please make it configurable.