-
Notifications
You must be signed in to change notification settings - Fork 514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bugfix: RemoveAll #329
bugfix: RemoveAll #329
Conversation
when i RemoveAll lib directory, it also Removed libs directory
and you need to press on the |
merge pls :D |
@yearnfar I don't fully understand what the problem is, you want the directory to be also removed but it currently isn't? Can you please add a test for this problem? |
you add a trailing filepath separator in order to prevent other directories starting with the same prefix from being deleted as well as the one you actually want to delete. General thought: For MemMapFs this should suffice as iirc it does add a trailing slash at the end of a directory name. |
…1017) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [github.com/spf13/afero](https://togithub.com/spf13/afero) | require | minor | `v1.7.0` -> `v1.8.2` | --- ### Release Notes <details> <summary>spf13/afero</summary> ### [`v1.8.2`](https://togithub.com/spf13/afero/releases/tag/v1.8.2) [Compare Source](https://togithub.com/spf13/afero/compare/v1.8.1...v1.8.2) - Fix gcsfs RemoveAll by [@​typerat](https://togithub.com/typerat) in [https://github.com/spf13/afero/pull/340](https://togithub.com/spf13/afero/pull/340) - bugfix: RemoveAll by [@​yearnfar](https://togithub.com/yearnfar) in [https://github.com/spf13/afero/pull/329](https://togithub.com/spf13/afero/pull/329) ### [`v1.8.1`](https://togithub.com/spf13/afero/compare/v1.8.0...v1.8.1) [Compare Source](https://togithub.com/spf13/afero/compare/v1.8.0...v1.8.1) ### [`v1.8.0`](https://togithub.com/spf13/afero/releases/tag/v1.8.0) [Compare Source](https://togithub.com/spf13/afero/compare/v1.7.1...v1.8.0) - sftpfs: Add support for Readdirnames and Readdir - CacheOnReadFs: Call OpenFile instead of Open in CacheOnReadFs.OpenFile ### [`v1.7.1`](https://togithub.com/spf13/afero/compare/v1.7.0...v1.7.1) [Compare Source](https://togithub.com/spf13/afero/compare/v1.7.0...v1.7.1) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 3am on Monday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate).
when i RemoveAll lib directory, it also Removed libs directory