Android: Imported address wallet will not show it under "request" #6852
Comments
|
In fact, this might not be a problem. You can still get the address by going to "Addresses" -> Click on the address to get the QR code and be able to receive in watch only mode. You cannot create a request because a request by itself includes a fresh address. I will leave this issue open for few more hours so more eyes can see it, and if we think current behavior is good we can close it. |
|
we should probably do what qt does |
|
In this case we have a minor undesired behavior. In qt, it will warn that it's an imported wallet, and it's recommended to have a deterministic wallet and etc. but if you click yes proceed it will generate the payment request marked as "paid" and flagged with red, as we do for funded / used addresses. This is ok and expected. Kivy does not give you that pop-up, it only says there are no usuable addresses. So you cannot proceed with the payment request further. See: and: |
|
Can someone test this for CLI / console too? So we apply the fix with this warning everywhere? |
robertmin1
pushed a commit
to robertmin1/electrum-nmc
that referenced
this issue
Oct 31, 2023
This script filters linter warnings to only find issues relative to upstream Electrum. Namecoin / AuxPoW: Fix linter warnings in blockchain.py Namecoin / AuxPoW: Fix linter warnings in merkle.py fix spesmilo#4561 fix spesmilo#4503: in kivy, catch NotEnoughFunds raised on open channel. kivy: disable send amount button if lightning invoice has an amount, and fix spesmilo#6526 Qt: do not save pending invoice before the user has confirmed payment kivy screens: initialize is_max (fix spesmilo#6813) kivy: dismiss invoice_dialog before delete (fix spesmilo#6816) revert a9fc440, use Clock.schedule_interval to set address. Fixes spesmilo#6810 and spesmilo#6817 Use os._exit() for FORKed child browser opener process. Fixes spesmilo#6404. On Linux, when Electrum is executed from Appimage file, to prevent system library inconsistence for Electrum and web browser and all issues involving that, Electrum starts web browser and opens web page upon clicking on 'View on block explorer' by fork()'ing the process, unsetting its custom LD_LIBRARY_PATH environment variable in the child process, and calling webbrowser.open(). Due to incorrect usage of sys.exit() instead of os._exit() for child process, Electrum (parent) can't be terminated and endlessly waits for child process upon exit, while child process does nothing but still exists. Fix this issue by using os._exit function, which should be used for child processes (not only in Python). kivy: wizard does not need Factory kivy: fix open channel with "max" amt related spesmilo#6169 E | gui.kivy.uix.dialogs.lightning_open_channel.LightningOpenChannelDialog | Problem opening channel Traceback (most recent call last): File "/home/user/wspace/electrum/electrum/gui/kivy/uix/dialogs/lightning_open_channel.py", line 167, in do_open_channel chan, funding_tx = lnworker.open_channel( File "/home/user/wspace/electrum/electrum/lnworker.py", line 859, in open_channel if funding_sat > LN_MAX_FUNDING_SAT: TypeError: '>' not supported between instances of 'str' and 'int' kivy: (fix) clicking "max" to send would raise for empty wallet fix spesmilo#6812 mnemonic.make_seed: de-duplicate num_bits default magic number plugins: remove 'on_new_window' hook kivy: remove redundant declaration network: set _loop_thread again as it helps debugging related: spesmilo#6825 Qt: keep pending_invoice logic in main_window (follow-up 56579c2, fixes spesmilo#5829) gitignore: add some more build artifacts dependencies: rm python-ecdsa rerun freeze_packages kivy: ensure WizardDialog.on_release is not executed more than once (see spesmilo#6822) dnspython: fix deprecation warnings when using dnspython 2.0 related: spesmilo#6828 qt swap dialog: fix enabling OK button fixes spesmilo#6831 keystore: handle unusual derivation paths in PSBT If a tx contained a derivation path for a pubkey, with a length=2 der suffix, with the first element of the suffix not in (0, 1), with a fingerprint that matches either our root or intermediate fp, then processing that tx would raise and result in a crash reporter. Traceback (most recent call last): File ".../electrum/electrum/gui/qt/main_window.py", line 2718, in do_process_from_text self.show_transaction(tx) File ".../electrum/electrum/gui/qt/main_window.py", line 1041, in show_transaction show_transaction(tx, parent=self, desc=tx_desc) File ".../electrum/electrum/gui/qt/transaction_dialog.py", line 84, in show_transaction d = TxDialog(tx, parent=parent, desc=desc, prompt_if_unsaved=prompt_if_unsaved) File ".../electrum/electrum/gui/qt/transaction_dialog.py", line 680, in __init__ self.set_tx(tx) File ".../electrum/electrum/gui/qt/transaction_dialog.py", line 218, in set_tx tx.add_info_from_wallet(self.wallet) File ".../electrum/electrum/transaction.py", line 1944, in add_info_from_wallet wallet.add_input_info(txin, only_der_suffix=only_der_suffix) File ".../electrum/electrum/wallet.py", line 1573, in add_input_info is_mine = self._learn_derivation_path_for_address_from_txinout(txin, address) File ".../electrum/electrum/wallet.py", line 2609, in _learn_derivation_path_for_address_from_txinout pubkey, der_suffix = ks.find_my_pubkey_in_txinout(txinout, only_der_suffix=True) File ".../electrum/electrum/keystore.py", line 155, in find_my_pubkey_in_txinout path = self.get_pubkey_derivation(pubkey, txinout, only_der_suffix=only_der_suffix) File ".../electrum/electrum/keystore.py", line 391, in get_pubkey_derivation if not test_der_suffix_against_pubkey(der_suffix, pubkey): File ".../electrum/electrum/keystore.py", line 368, in test_der_suffix_against_pubkey if pubkey != self.derive_pubkey(*der_suffix): File ".../electrum/electrum/keystore.py", line 491, in derive_pubkey assert for_change in (0, 1) AssertionError kivy: add on_dismiss method to crash reporter dialog qt StatusBarButton: use QToolButton instead of QPushButton related: spesmilo#6299 qt StatusBarButton: use custom theme for macOS if using default theme prepare 4.0.7 update locale update locale Namecoin / AuxPoW: contrib: make lint_diff.sh more robust This makes the script work properly when run from a commit that isn't the tip of a branch. rerun freeze_packages trustedcoin: fix two-step wallet creation (offline->online) got broken in c46fbf0 kivy: dismiss wizard dialog before calling go_back test_wallet_vertical: add test case for pre-2.7 "2fa" seed mnemonic: tighten seed_type check for old "2fa" type seeds Seeds in the set difference could already not be restored: they raised an exception in the wizard; now these are not recognised as valid seeds anymore (so e.g. OK button in wizard will be disabled). Also see comments in code. cleanup, remove if statement (follow-up 13b05f6) keystore: ignore fingerprint for pubkeys in psbt, try to match all keys transaction: put full derivation paths into PSBT by default There are three export options for exporting a PSBT. The default option previously only put derivation path suffixes for pubkeys (paths relative to the intermediate xpub), now it puts the full path (if is known by the keystore). The "export for hardware device; include xpubs" option works same as before: it puts both full paths and also global xpubs into the PSBT. Hence the difference between the default option and the "include xpubs" option is now only that the latter puts global xpubs into the PSBT. This change is largely made for user-convenient in mind. Now exporting a PSBT should be less error-prone: particularly for the single-signer coldcard with sdcard usage, the default option will now work. closes spesmilo#5969 related spesmilo#5955 Save height in invoices, use it to determine invoice status (fixes spesmilo#6609) network: when switching servers, don't wait for old interface to close The GUI blocks until network.set_parameters returns when switching servers, which waits for switch_to_interface, which used to wait until interface.close() returns. interface.close() tries to flush buffered writes to the wire, with a 30 sec timeout. If the server or the network connection is slow, flushing the buffer can take several seconds. In particular, servers running Fulcrum always seem to timeout in this case, freezing the GUI for 30 seconds (when switching away). lnworker: remove channel if it was not saved successfully after creation kivy: initialize app.android_backups from config, and show error message if save_backup raises an exception build: don't allow setuptools to sneakily install build-time deps see https://pip.pypa.io/en/stable/reference/pip_install/#controlling-setup-requires > Setuptools offers the setup_requires setup() keyword for specifying > dependencies that need to be present in order for the setup.py > script to run. Internally, Setuptools uses easy_install to > fulfill these dependencies. > pip has no way to control how these dependencies are located. > None of the package index options have an effect. With these changes, we will now instead hard fail if this were to happen. related: spesmilo#5859 (comment) network: increase MOST_RELAXED default timeout to 10 minutes related: spesmilo#6741 synchronizer: request missing txs for addresses in random order as discussed in issue spesmilo#6697, users with large wallets or slow connections may never see their initial request-missing-tx run complete, if we always use the same sync order. This commit shuffles the addresses being requested every time a new request round happens, so that (if enough time passes and enough initial state requests are attempted) we will always get the latest state for each address, regardless of how quickly the connection times out on us wallet: use height to determine request status (similar to outgoing invoices) kivy: allow address reuse in imported wallets. (fix spesmilo#6852) kivy: move "lightning" (gossip) btn inside "channels" dialog and show toast msg when opening "channels" dialog if lightning is not available for wallet qt swap dialog: attempt at clearer logic (at the cost of more lines) fixes spesmilo#6853 swaps: disable button if no channel present swaps: limit forward amount to receivable amount on lightning swaps: fix normal amount formulas In a normal (forward) swap (onchain->offchain): send_amount = receive_amount * (1 + service_percentage) + normal_fee , and vice versa: receive_amount = (send_amount + normal_fee) / (1 + service_percentage) , i.e., the service fee is charged on the received offchain amount. wallet_db: impl convert_version_33: put 'height' field into invoices The 'height' field was added in spesmilo@cdfaaa2 At the time we thought we could just add it with a default value without a db upgrade; however the issue is that if old code tries to open a new db, it will fail (due to unexpected new field). Hence it is better to do an explicit conversion where old code *knows* it cannot open the new db. E | gui.qt.ElectrumGui | Traceback (most recent call last): File "...\electrum\electrum\gui\qt\__init__.py", line 257, in start_new_window wallet = self.daemon.load_wallet(path, None) File "...\electrum\electrum\daemon.py", line 488, in load_wallet db = WalletDB(storage.read(), manual_upgrades=manual_upgrades) File "...\electrum\electrum\wallet_db.py", line 72, in __init__ self.load_data(raw) File "...\electrum\electrum\wallet_db.py", line 103, in load_data self._after_upgrade_tasks() File "...\electrum\electrum\wallet_db.py", line 189, in _after_upgrade_tasks self._load_transactions() File "...\electrum\electrum\util.py", line 408, in <lambda> return lambda *args, **kw_args: do_profile(args, kw_args) File "...\electrum\electrum\util.py", line 404, in do_profile o = func(*args, **kw_args) File "...\electrum\electrum\wallet_db.py", line 1139, in _load_transactions self.data = StoredDict(self.data, self, []) File "...\electrum\electrum\json_db.py", line 79, in __init__ self.__setitem__(k, v) File "...\electrum\electrum\json_db.py", line 44, in wrapper return func(self, *args, **kwargs) File "...\electrum\electrum\json_db.py", line 105, in __setitem__ v = self.db._convert_dict(self.path, key, v) File "...\electrum\electrum\wallet_db.py", line 1182, in _convert_dict v = dict((k, Invoice.from_json(x)) for k, x in v.items()) File "...\electrum\electrum\wallet_db.py", line 1182, in <genexpr> v = dict((k, Invoice.from_json(x)) for k, x in v.items()) File "...\electrum\electrum\invoices.py", line 108, in from_json return OnchainInvoice(**x) TypeError: __init__() got an unexpected keyword argument 'height' prepare release 4.0.8 Support binary encoding of names in Electrum-NMC GUI (exposed as hex in GUI)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
On Android, if you would like to import an address to have it as watch only, it will allow you to create the wallet, display the correct balance and transaction history but if you go to "receive" it will say that there are too many pending requests and there's no usuable address. This is not too good if you want to have such an wallet as a cold storage, maybe you want to go somewhere and people scan that QR code of that address to send some coins, while you have no possibility to spend them of course you need to at least be able to receive.
This happens both if you have a single watch only address in the wallet or more addresses that are all used.
I did not have the chance to try with private key import (or public key import) because this would defeat the purpose of what i was trying to achieve but my guess is that it happens the same -- anyway we should check this too while addressing this issue.
The text was updated successfully, but these errors were encountered: