-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve readme #13
Improve readme #13
Conversation
An improvement to this draft would be a screenshot of the "Create your first wiki page for user/repo" page with a circle around the button in the "you must create a dummy page first" section I did this in Andrew-Chen-Wang/github-wiki-action#22 I also do try to do this in readmes but sometimes forget (like I did here). I think it's a nice touch that's an addon type thing, but not required to understand the content of a section demo: https://gist.github.com/jcbhmr/5fa35ec1c7208018e9dce2a9e06af0cf |
Another improvement might be to add in the github and github actions badges that I use to be like "here's what you can use this tool with" like I did in Andrew-Chen-Wang/github-wiki-action#22 |
@spenserblack opinions on options in PR post? table vs |
BTW, I see you're using ❗ and Markdown> **Warning**
> This is a warning Rendered(should be an admonition, assuming no changes to GH's Markdown parsing)
Personally, I prefer the emojis, but I figured you might be interested. |
@spenserblack Yep! I saw that new feature, but I have a distaste for it because
|
@spenserblack I've commented on the review comments; and while I did make a valiant defense of my own coding/readme/writing style, I will conform with this repo's styleguide. ✍️ |
@spenserblack I saw somewhere (can't find it again) that you were curious how Note that both the "under construction" image and the code https://carbon.now.sh image are centered with here's cli terminal output screenshot: here's original web view: I think it's pretty cool that they've got a fancy terminal renderer (wow). I wonder if it's based on https://github.com/charmbracelet/glow ? |
It is! Edit: Nevermind, I got the dependencies reversed 😆 |
1. Expands the first p 2. Adds comments describing inputs 3. Moves notice about first github page to below example code 4. Aligns image to the right 5. Adds section about pushing to other repositories 6. Fixes previously non-existant link to github actions marketplace (caught by https://dlaa.me/markdownlint/ this time) Formatted with https://prettier.io/playground/ --proseWrap: always Checked with https://dlaa.me/markdownlint/
Signifying "usable with" or "use with"
ChatGPT says this is a 9/10 readme 🤣 as of https://github.com/jcbhmr/actions-wiki/commit/f6995de86b90fc85f6c253d8d6974fed31f2d3c4
|
Made some changes. Namely I added a sub-section in the "Usage" section to discuss cross-repo publishing /cc @spenserblack |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! One last nitpick.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for putting up with my nitpicks! 😆
Stumbled on this recently. I haven't dug into it yet, but I figured it could be relevant, and you might be interested. https://github.com/RichardLitt/standard-readme |
This PR would... (checkboxes track draft progress)
Add a header image to the top of the readme to grab attention (currently placeholder cat)<dl>
vs in-code)Regarding table vs ... here's the options that I found: (copied from Andrew-Chen-Wang/github-wiki-action#22 (comment))
@spenserblack looking for active ✅ approval/opinion on your favorite
1: table
2: In YAML
https://github.com/actions/checkout#readme
3: Literal list
https://github.com/wow-actions/contributors-list#readme
4: Headers for each option
https://github.com/veracode/veracode-sandboxes-helper#readme
5: dl description list
<dl>
(couldn't find any GitHub Action examples of this)Closes #9