Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add VMO cluster deployment DOC-1358 #46

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

addetz
Copy link
Contributor

@addetz addetz commented Jan 13, 2025

Describe the Change

This PR adds the VMO cluster deployment and VM creation example.

Review Changes

🎫 DOC-1358

@addetz addetz requested a review from a team as a code owner January 13, 2025 15:59
@addetz addetz requested review from karl-cardenas-coding, lennessyy and achuribooks and removed request for a team January 13, 2025 15:59
@addetz addetz force-pushed the add-vmo-cluster-doc-1358 branch 10 times, most recently from c127eb5 to d1ac9fe Compare January 13, 2025 20:33
docs: add creation of virtual machine

docs: add test cases DOC-1358

docs: add readme DOC-1358
@addetz addetz force-pushed the add-vmo-cluster-doc-1358 branch from d1ac9fe to 4698a97 Compare January 13, 2025 20:34
Copy link
Contributor

@caroldelwing caroldelwing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations on making this configuration work 👏 This will really help our users.
Also the test cases cover everything we need 🚀

@@ -0,0 +1,74 @@
# Deploy and Manage VMs using Palette VMO

This folder contains the demo code for the **Deploy and Manage VMs using Palette VMO** tutorial.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This folder contains the demo code for the **Deploy and Manage VMs using Palette VMO** tutorial.
This folder contains the demo code for the **Deploy and Manage VMs using Palette VMO** tutorial.

We could add the link once you choose the title :)

Comment on lines +11 to +14
######
# MAAS
######

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
######
# MAAS
######

I think we can remove this, as this tutorial only covers MAAS :)

Comment on lines +51 to +52
count = var.deploy-maas-vm ? 1 : 0
depends_on = [spectrocloud_cluster_maas.maas-cluster]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice 😎

disable_root: false
runcmd:
- apt-get update
- apt-get install -y qemu-guest-agent
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious. Why do we need qemu installed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants