Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PEM-4967: CAPA changes for AWS Secret/TopSecret Region #933

Open
wants to merge 11 commits into
base: spectro-master
Choose a base branch
from
Open

PEM-4967: CAPA changes for AWS Secret/TopSecret Region #933

wants to merge 11 commits into from
+566 −88

Conversation

pavansokkenagaraj
Copy link

@pavansokkenagaraj pavansokkenagaraj commented Jan 16, 2025 •
edited
Loading

No description provided.

@pavansokkenagaraj pavansokkenagaraj changed the base branch from main to spectro-master January 16, 2025 19:30
@pavansokkenagaraj pavansokkenagaraj force-pushed the pem-4967 branch 10 times, most recently from 4c271e7 to 4a339ae Compare January 21, 2025 04:03
@pavansokkenagaraj pavansokkenagaraj changed the title PEM-4967: disable fips ep for sc2s PEM-4967: CAPA changes for AWS Secret/TopSecret Region Jan 21, 2025
@pavansokkenagaraj pavansokkenagaraj force-pushed the pem-4967 branch 4 times, most recently from a44eca1 to f52ed49 Compare January 23, 2025 05:51
@AmitSahastra AmitSahastra self-requested a review January 27, 2025 03:43
AmitSahastra
AmitSahastra approved these changes Jan 27, 2025
View reviewed changes
Copy link

@AmitSahastra AmitSahastra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@spectro-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AmitSahastra, pavansokkenagaraj
To complete the pull request process, please assign after the PR has been reviewed.
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AmitSahastra AmitSahastra AmitSahastra approved these changes

Assignees
No one assigned
Labels
size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pavansokkenagaraj @spectro-prow @AmitSahastra