Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PCP-3592: [Upstream] fix: propagate AdditionalTags from AWSCluster to storage volumes #905

Merged
merged 2 commits into from
Oct 17, 2024

Conversation

rrpolanco
Copy link

@rrpolanco rrpolanco commented Oct 10, 2024

Cherry-pick upstream change to propagate additional tags to EBS storage volumes.

What type of PR is this?

/kind bug

What this PR does / why we need it:

Enables user tags to be applied to EBS root storage volumes.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes PCP-3592

Special notes for your reviewer:

Pulling commit a0e5849 from upstream which addresses PCP-3592.

Checklist:

  • squashed commits
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

@spectro-prow
Copy link

spectro-prow commented Oct 10, 2024

@rrpolanco: The label(s) kind/bug cannot be applied, because the repository doesn't have them

In response to this:

Cherry-pick upstream change to propagate additional tags to EBS storage volumes.

What type of PR is this?

/kind bug

What this PR does / why we need it:

Enables user tags to be applied to EBS root storage volumes.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes PCP-3592

Special notes for your reviewer:

Pulling commit a0e5849 from upstream which addresses PCP-3592.

Checklist:

  • squashed commits
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

…altags-root-volumes

fix: propagate AdditionalTags from AWSCluster to storage volumes
@rrpolanco rrpolanco changed the base branch from main to spectro-master October 10, 2024 22:34
@rrpolanco rrpolanco changed the title PCP-3592: [Upstream] fix: propagate AdditionalTags from AWSCluster to storage volumes [WIP] PCP-3592: [Upstream] fix: propagate AdditionalTags from AWSCluster to storage volumes Oct 10, 2024
@spectro-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rrpolanco, sadysnaat
To complete the pull request process, please assign after the PR has been reviewed.
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rrpolanco rrpolanco changed the title [WIP] PCP-3592: [Upstream] fix: propagate AdditionalTags from AWSCluster to storage volumes PCP-3592: [Upstream] fix: propagate AdditionalTags from AWSCluster to storage volumes Oct 17, 2024
@rrpolanco rrpolanco merged commit 8010300 into spectro-master Oct 17, 2024
rrpolanco added a commit that referenced this pull request Oct 21, 2024
This reverts commit 8010300, reversing
changes made to 93b0586.
rrpolanco added a commit that referenced this pull request Oct 21, 2024
This reverts commit 8010300, reversing
changes made to 93b0586.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants