PCP-618: capa fix hardcoded role arn for aws iam authenticator #519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sadysnaat
reviewed
Dec 7, 2022
sadysnaat
approved these changes
Dec 7, 2022
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: AmitSahastra, sadysnaat The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
AmitSahastra
added a commit
that referenced
this pull request
Jan 13, 2023
AmitSahastra
added a commit
that referenced
this pull request
Jan 16, 2023
AmitSahastra
added a commit
that referenced
this pull request
Feb 15, 2023
AmitSahastra
added a commit
that referenced
this pull request
Apr 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
State
READY
What is the purpose of the pull request
CAPA fix hardcoded role ARN for AWS IAM authenticator.
Implementation
Issue: Partition values need to be different for default "aws" and "aws-us-gov", hardcoded roles/policies with default partition of "aws" does not work with "aws-us-gov".
Fix: Modified code to look for partition/region and replace ARN partition based on it.
Committer checklist
Verified on:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Checklist: