Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify stack frame parsing #637

Merged

Conversation

0xced
Copy link
Contributor

@0xced 0xced commented Nov 24, 2021

This is the natural extension of #513 which already removed a lot of regex parsing.

The ExceptionParser class is renamed into ExceptionConverter because there is no more string parsing performed at all. Exception is converted into ExceptionInfo and StackFrame is converted into StackFrameInfo.

This is the natural extension of spectreconsole#513 which already removed a lot of regex parsing. 

The `ExceptionParser` class is renamed into `ExceptionConverter` because there is no more string parsing performed at all. `Exception` is converted into `ExceptionInfo` and `StackFrame` is converted into `StackFrameInfo`.
@patriksvensson patriksvensson merged commit 8e762e4 into spectreconsole:main Dec 15, 2021
@patriksvensson
Copy link
Contributor

Merged! Thank you for your contribution. Much appreciated! 👍

@0xced 0xced deleted the simplify-stack-frame-parsing branch December 15, 2021 23:37
0xced added a commit to 0xced/spectre.console that referenced this pull request Jan 19, 2022
Now that exceptions are not _parsed_ anymore (spectreconsole#513 and spectreconsole#637), keeping the `ExceptionInfo` and `StackFrameInfo` internal classes doesn't make much sense anymore. The `Exception` and `StackFrame` types can be used by the `ExceptionFormatter` class directly, without conversion.
0xced added a commit to 0xced/spectre.console that referenced this pull request Jan 20, 2022
Now that exceptions are not _parsed_ anymore (spectreconsole#513 and spectreconsole#637), keeping the `ExceptionInfo` and `StackFrameInfo` internal classes doesn't make much sense anymore. The `Exception` and `StackFrame` types can be used by the `ExceptionFormatter` class directly, without conversion.
phil-scott-78 pushed a commit that referenced this pull request Feb 3, 2022
Now that exceptions are not _parsed_ anymore (#513 and #637), keeping the `ExceptionInfo` and `StackFrameInfo` internal classes doesn't make much sense anymore. The `Exception` and `StackFrame` types can be used by the `ExceptionFormatter` class directly, without conversion.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants