Simplify stack frame parsing #637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the natural extension of spectreconsole#513 which already removed a lot of regex parsing. The `ExceptionParser` class is renamed into `ExceptionConverter` because there is no more string parsing performed at all. `Exception` is converted into `ExceptionInfo` and `StackFrame` is converted into `StackFrameInfo`.
patriksvensson
approved these changes
Dec 15, 2021
|
Merged! Thank you for your contribution. Much appreciated! 👍 |
0xced
added a commit
to 0xced/spectre.console
that referenced
this pull request
Jan 19, 2022
Now that exceptions are not _parsed_ anymore (spectreconsole#513 and spectreconsole#637), keeping the `ExceptionInfo` and `StackFrameInfo` internal classes doesn't make much sense anymore. The `Exception` and `StackFrame` types can be used by the `ExceptionFormatter` class directly, without conversion.
0xced
added a commit
to 0xced/spectre.console
that referenced
this pull request
Jan 20, 2022
Now that exceptions are not _parsed_ anymore (spectreconsole#513 and spectreconsole#637), keeping the `ExceptionInfo` and `StackFrameInfo` internal classes doesn't make much sense anymore. The `Exception` and `StackFrame` types can be used by the `ExceptionFormatter` class directly, without conversion.
This was referenced Mar 27, 2022
Merged
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the natural extension of #513 which already removed a lot of regex parsing.
The
ExceptionParserclass is renamed intoExceptionConverterbecause there is no more string parsing performed at all.Exceptionis converted intoExceptionInfoandStackFrameis converted intoStackFrameInfo.