(#555) Clarify ITypeResolver returns null
#620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and does not throw on unresolvable types. Also changed the TypeResolverAdapter to adhere to those expectations and removed the now no longer needed try-catch from CommandPropertyBinder.
as a very simple test harness to test implementations of ITypeRegistrar / ITypeResolver
nils-a
force-pushed
the
feature/GH-555
branch
from
24e351d
to
8765dc9
Compare
This was referenced Nov 14, 2021
This was referenced Nov 30, 2021
nils-a
added a commit
to nils-a/spectre.console
that referenced
this pull request
Jan 1, 2022
to adhere to the specifications set in spectreconsole#620
patriksvensson
pushed a commit
that referenced
this pull request
Jan 2, 2022
to adhere to the specifications set in #620
1 task
1 task
This was referenced Mar 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and does not throw on unresolvable types.
Also changed the
TypeResolverAdapterto adhereto those expectations and removed the now no longer
needed try-catch from
CommandPropertyBinder.