Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add output abstraction and reorganize profile #372

Merged
merged 1 commit into from
Apr 14, 2021
Merged

Add output abstraction and reorganize profile #372

merged 1 commit into from
Apr 14, 2021

Conversation

patriksvensson
Copy link
Contributor

  • Moves ColorSystem from Profile to Capabilities
  • Renames Tty to IsTerminal
  • Adds IAnsiConsoleOutput to make output more flexible

Closes #343
Closes #359
Closes #369

* Moves ColorSystem from Profile to Capabilities
* Renames Tty to IsTerminal
* Adds IAnsiConsoleOutput to make output more flexible

Closes #343
Closes #359
Closes #369
@patriksvensson patriksvensson marked this pull request as draft April 13, 2021 16:09
@patriksvensson patriksvensson marked this pull request as ready for review April 13, 2021 22:25
@patriksvensson
Copy link
Contributor Author

@phil-scott-78 I think this one is ready for review

@phil-scott-78
Copy link
Contributor

This all looks good to me, and I ran it through its paces with my apps and the examples. Gonna merge it to get it out there for people to test out before the next release.

@phil-scott-78 phil-scott-78 merged commit 3e2eea7 into spectreconsole:main Apr 14, 2021
@patriksvensson patriksvensson deleted the feature/GH-343 branch April 14, 2021 05:28
@phil-scott-78 phil-scott-78 mentioned this pull request Apr 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants