Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(#1317) added a minimal PR template #1318

Merged
merged 1 commit into from
Sep 27, 2023
Merged

(#1317) added a minimal PR template #1318

merged 1 commit into from
Sep 27, 2023

Conversation

nils-a
Copy link
Contributor

@nils-a nils-a commented Sep 27, 2023

fixes #1317

  • I have read the Contribution Guidelines
  • I have commented on the issue above and discussed the intended changes
  • A maintainer has signed off on the changes and the issue was assigned to me
  • All newly added code is adequately covered by tests
  • All existing tests are still running without errors
  • The documentation was modified to reflect the changes OR no documentation changes are required.

Changes

Added a simple PR template, in Markdown.

@nils-a nils-a requested a review from a team September 27, 2023 06:30
patriksvensson
patriksvensson approved these changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@patriksvensson patriksvensson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@patriksvensson patriksvensson merged commit e2a6748 into spectreconsole:main Sep 27, 2023
6 checks passed
@nils-a nils-a deleted the feature/GH-1317 branch September 27, 2023 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patriksvensson patriksvensson patriksvensson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a PR template
2 participants
@nils-a @patriksvensson