Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes TextPath rendering bugs #1308

Merged
merged 1 commit into from
Sep 18, 2023

Conversation

patriksvensson
Copy link
Contributor

  • Do not emit line break when rendering
  • Don't be greedy when measuring.
  • Fix a condition that decides if the path fits in the allotted space.

Closes #1307

* Do not emit line break when rendering
* Don't be greedy when measuring.
* Fix a condition that decides if the path fits in the allotted space.

Closes spectreconsole#1307
Copy link
Contributor

@nils-a nils-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nils-a nils-a merged commit 943c045 into spectreconsole:main Sep 18, 2023
6 checks passed
@patriksvensson patriksvensson deleted the feature/GH-1307 branch September 18, 2023 06:22
@kamronbatman
Copy link

kamronbatman commented Nov 10, 2023

I need this bug fix, is there any ETA on a new release? Looks like the last release was a while ago. cc @patriksvensson

@patriksvensson
Copy link
Contributor Author

@kamronbatman We're planning a new release, but we need to get some other stuff in first and test them a bit more. Until that you can always use one of the pre-release versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TextPath behaves strange together with columns
3 participants