Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to pass example args using params syntax #1166

Merged
merged 3 commits into from
May 12, 2023

Conversation

seclerp
Copy link
Contributor

@seclerp seclerp commented Feb 18, 2023

The most used way of specifying the examples is by hardcoding values. So it will be much easier without additional new [] { ... } syntax noise, but with the same outcome.

With params you are still able to specify items as an array, so the compatibility is kept.

@dnfadmin
Copy link

dnfadmin commented Feb 18, 2023

CLA assistant check
All CLA requirements met.

@FrankRay78 FrankRay78 self-requested a review May 10, 2023 13:07
@FrankRay78 FrankRay78 changed the base branch from main to renovate/dotnet-sdk-7.x May 12, 2023 11:05
@FrankRay78 FrankRay78 changed the base branch from renovate/dotnet-sdk-7.x to main May 12, 2023 11:05
@FrankRay78 FrankRay78 merged commit 404b052 into spectreconsole:main May 12, 2023
@FrankRay78
Copy link
Contributor

Thank you @seclerp for this high-quality contribution, it's much appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants