Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor Refactorings for Deliverable II #1081

Merged
merged 1 commit into from
May 14, 2023

Conversation

Elisha-Aguilera
Copy link
Contributor

As stated, minor refactorings and adjustments for Deliverable II. Pull Request made against your fork as not to interfere with the main project.

@FrankRay78 FrankRay78 self-requested a review May 12, 2023 10:50
@FrankRay78
Copy link
Contributor

FrankRay78 commented May 12, 2023

Dear @Elisha-Aguilera, thank you for this PR. I'm sorry about how long it's taken to get around to reviewing it, and thanks for your patience. It's quite old and so there are a few conflicts, but I plan to checkout locally, rebase, have a look through at what's still valid, then force push. If you get around to it first, please feel free to do this yourself and re-push. Otherwise I'll make time over the next week and be in touch then..

UPDATE - I've rebased and resolved conflicts, and force pushed back to your branch. Please update your local repo/branch if making any further changes.

- Corrected minor spelling mistake
- Replaced lambda with Method Group

Minor refactor: replaced lambda with Method Group

Minor Refactorings
- Inlined variables
- Removed redundant, unnecessary local variable assignment

Minor Refactor, improved readability
- Replaced conditional symbols with conditional operators
- Removed unreadable code

is or operators
@FrankRay78 FrankRay78 changed the base branch from main to renovate/dotnet-sdk-7.x May 13, 2023 17:14
@FrankRay78 FrankRay78 changed the base branch from renovate/dotnet-sdk-7.x to main May 13, 2023 17:14
@FrankRay78
Copy link
Contributor

Hello @Elisha-Aguilera, I've reviewed this PR and can merge it once you've accepted the Contributor License Agreement(CLA) - please see the comment above from microsoft-github-policy-service as to how to do this. Thank you for submitting this high-quality PR which improves the codebase for us all.

@FrankRay78 FrankRay78 merged commit 018f4eb into spectreconsole:main May 14, 2023
@FrankRay78
Copy link
Contributor

Thank you @Elisha-Aguilera, this PR is now merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants