Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add method to replace in sqlite #190

Merged
merged 2 commits into from
Dec 16, 2024

Conversation

adamhathcock
Copy link
Member

Copy link

linear bot commented Dec 16, 2024

@adamhathcock adamhathcock enabled auto-merge (squash) December 16, 2024 11:41
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.

Project coverage is 66.52%. Comparing base (defcee1) to head (935a129).

Files with missing lines Patch % Lines
src/Speckle.Sdk/SQLite/SQLiteJsonCacheManager.cs 0.00% 7 Missing ⚠️
...k/Serialisation/V2/DummySendServerObjectManager.cs 0.00% 1 Missing ⚠️
...s/Speckle.Sdk.Serialization.Tests/DetachedTests.cs 0.00% 1 Missing ⚠️
...k.Serialization.Tests/DummySqLiteReceiveManager.cs 0.00% 1 Missing ⚠️
....Sdk.Serialization.Tests/DummySqLiteSendManager.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##              dev     #190       +/-   ##
===========================================
+ Coverage   54.21%   66.52%   +12.30%     
===========================================
  Files         236      252       +16     
  Lines        9507    10165      +658     
  Branches     1074     1075        +1     
===========================================
+ Hits         5154     6762     +1608     
+ Misses       4098     3057     -1041     
- Partials      255      346       +91     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@oguzhankoral oguzhankoral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am approving just for the sake of another approved PR before. We shouldn't have changed ConfigBinding at the very beginning at all. Because the contract was only on having sync way of sqlite for ConnectorsFileData not changing async sqlite for DUI3Config

@adamhathcock adamhathcock merged commit 675d896 into dev Dec 16, 2024
4 checks passed
@adamhathcock adamhathcock deleted the adam/cnx-935-dui3-config-bindings-not-working branch December 16, 2024 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants