Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:(navis) - CNX-961 - Removed shortcut from plugin registration #453

Conversation

jsdbroughton
Copy link
Contributor

Having a shortcut is largely unnecessary so removing this fixes the conflict of shortcut clashes

@jsdbroughton jsdbroughton added the enhancement New feature or request label Dec 18, 2024
Copy link

linear bot commented Dec 18, 2024

@jsdbroughton jsdbroughton requested review from oguzhankoral and removed request for dogukankaratas December 18, 2024 12:11
@jsdbroughton jsdbroughton marked this pull request as ready for review December 18, 2024 12:11
Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 9.40%. Comparing base (f10a547) to head (67fef18).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@          Coverage Diff          @@
##             dev    #453   +/-   ##
=====================================
  Coverage   9.40%   9.40%           
=====================================
  Files        223     223           
  Lines       4222    4222           
  Branches     497     497           
=====================================
  Hits         397     397           
  Misses      3809    3809           
  Partials      16      16           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adamhathcock adamhathcock enabled auto-merge (squash) December 20, 2024 08:51
…icts-with-internal-export-as
@adamhathcock adamhathcock merged commit f674024 into dev Dec 20, 2024
5 checks passed
@adamhathcock adamhathcock deleted the jonathon/cnx-961-ribbon-button-shortcut-conflicts-with-internal-export-as branch December 20, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants