Dimitrie/cnx 917 steel proxy elements do not get converted out #447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i will remove them
…s reliable?) and removes local dependency refs
reason: joined up beams would export wrong geometry
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #447 +/- ##
========================================
- Coverage 9.43% 9.40% -0.04%
========================================
Files 223 223
Lines 4208 4222 +14
Branches 487 497 +10
========================================
Hits 397 397
- Misses 3795 3809 +14
Partials 16 16 ☔ View full report in Codecov by Sentry. |
didimitrie
changed the title
didimitrie
changed the title
bimgeek
approved these changes
Dec 13, 2024
…get-converted-out
didimitrie
deleted the
dimitrie/cnx-917-steel-proxy-elements-do-not-get-converted-out
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rehash of the last PR, changes are that it's now valid across revit versions and should be (hopefully) exporting correct geometry even when structural elements are joined together.
Let's not merge until @bimgeek approves via a 2025 test (it's broken on my end)