Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sending caching #441

Merged
merged 6 commits into from
Dec 10, 2024
Merged

Fix sending caching #441

merged 6 commits into from
Dec 10, 2024

Conversation

adamhathcock
Copy link
Member

Part of https://linear.app/speckle/issue/CXPLA-143/sdk-slow-on-caching-and-general-sending

Fixed:

  • calculation of upload speed

Changed:

  • how progress looks: do all of serialize first and calculate tree ASAP. Then show upload/caching left only when serialization is done

Copy link

linear bot commented Dec 9, 2024

Copy link

codecov bot commented Dec 9, 2024

Codecov Report

Attention: Patch coverage is 0% with 16 lines in your changes missing coverage. Please review.

Project coverage is 9.43%. Comparing base (0341ebc) to head (0f7c55b).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
...eckle.Connectors.Common/Operations/SendProgress.cs 0.00% 15 Missing ⚠️
...onnectors.Common/Operations/PassthroughProgress.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             dev    #441      +/-   ##
========================================
- Coverage   9.45%   9.43%   -0.03%     
========================================
  Files        223     223              
  Lines       4199    4209      +10     
  Branches     483     487       +4     
========================================
  Hits         397     397              
- Misses      3786    3796      +10     
  Partials      16      16              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adamhathcock
Copy link
Member Author

Requires new SDK #441

@adamhathcock adamhathcock marked this pull request as ready for review December 10, 2024 11:38
@JR-Morgan JR-Morgan self-requested a review December 10, 2024 11:45
@JR-Morgan
Copy link
Member

tested in revit

Copy link
Member

@JR-Morgan JR-Morgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adamhathcock adamhathcock merged commit 0e0dd81 into dev Dec 10, 2024
5 checks passed
@adamhathcock adamhathcock deleted the fix-sending-caching branch December 10, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants