Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sdks to 205 (HashCode fix and nullability) #433

Merged
merged 4 commits into from
Dec 3, 2024
Merged

Conversation

adamhathcock
Copy link
Member

No description provided.

Copy link

codecov bot commented Dec 3, 2024

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 9.30%. Comparing base (f53e52b) to head (b045e31).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
...tShared/ToHost/Raw/Geometry/MeshConverterToHost.cs 0.00% 4 Missing ⚠️
.../ToHost/Raw/LocalToGlobalToDirectShapeConverter.cs 0.00% 2 Missing ⚠️
...Converters.RevitShared/RevitRootToHostConverter.cs 0.00% 1 Missing ⚠️
.../ToHost/Raw/Geometry/IRawEncodedObjectConverter.cs 0.00% 1 Missing ⚠️
...eckle.Connectors.Common/Conversion/ReportResult.cs 0.00% 1 Missing ⚠️
...e.Converters.Common/LocalToGlobalConverterUtils.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             dev    #433      +/-   ##
========================================
- Coverage   9.31%   9.30%   -0.01%     
========================================
  Files        225     225              
  Lines       4263    4266       +3     
  Branches     484     487       +3     
========================================
  Hits         397     397              
- Misses      3850    3853       +3     
  Partials      16      16              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@JR-Morgan JR-Morgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in Revit!

@adamhathcock adamhathcock enabled auto-merge (squash) December 3, 2024 14:59
@adamhathcock adamhathcock merged commit 48096fb into dev Dec 3, 2024
5 checks passed
@adamhathcock adamhathcock deleted the update-sdks branch December 3, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants