bjorn/cnx-835-add-converter-projects-and-top-level-converter #429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Project setup and basic definitions - Waiting for SDK update
- Abstract TopLevel converter - Requiring a lot of wrappers and addtional steps to get to converted CSiObject
CSiWrapperBase instead of ICSiWrapper correctly resolves all types
these are gross (just a poc for first send)
Simple organization
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #429 +/- ##
=====================================
Coverage 9.34% 9.34%
=====================================
Files 224 224
Lines 4246 4246
Branches 471 471
=====================================
Hits 397 397
Misses 3833 3833
Partials 16 16 ☔ View full report in Codecov by Sentry. |
clairekuang
reviewed
Dec 3, 2024
| } | ||
|
|
||
| // TODO: Frames could be further classified under Columns, Braces and Beams. Same for Shells which could be classified into walls, floors | ||
| public Collection GetAndCreateObjectHostCollection(ICSiWrapper csiObject, Collection rootObject) |
There was a problem hiding this comment.
This could be renamed to AddObjectCollectionToRoot, which would be more descriptive.
Why is the root collection being set to the newly created collection? probably can just return the created one directly.
There was a problem hiding this comment.
Under commit "AddObjectCollectionToRoot":
- Agreed. Renamed to
AddObjectCollectionToRoot - True, unnecessary line removed.
There was a problem hiding this comment.
This comment probably applies to Revit too Revit - SendCollectionManager.cs
PR comments: - Updated GetAndCreateObjectHostCollection to more descriptive name of AddObjectCollectionToRoot - Removing unnecessary rootObject = childCollection line
…ects-and-top-level-converter' into bjorn/cnx-835-add-converter-projects-and-top-level-converter
clairekuang
approved these changes
Dec 3, 2024
bjoernsteinhagen
deleted the
bjorn/cnx-835-add-converter-projects-and-top-level-converter
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation
Changes:
Speckle.Converters.CSiSharedprojectCSiWrappersto deal with CSiAPI not returning objectsScreenshots / Validation of changes:
Send working, with result below. Collection structure to be refined as part of CNX-829.
Checklist: