bjorn/cnx-828-shared-projects-for-connector #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- cPlugin.cs and Form1.cs in Shared defined as interfaces. Version specific implementations (basically just the namespaces) created in proj specific files - Plugins load and selection works in both ETABS versions
- Better to have a cPlugin base class which ETABS21 and 22 inherit. Reduced code duplication - Better project namespace structure
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #419 +/- ##
=====================================
Coverage 9.30% 9.30%
=====================================
Files 224 224
Lines 4234 4234
Branches 471 471
=====================================
Hits 394 394
Misses 3824 3824
Partials 16 16 ☔ View full report in Codecov by Sentry. |
bjoernsteinhagen
deleted the
bjorn/cnx-828-shared-projects-for-connector
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation
Changes:
Form1changed toSpeckleFormcPluginandSpeckleFormin Shared implements interfaces,ETABS22andETABS21just inherit base classes and correct namespaces, so that plugin loads in ETABSScreenshots:
ETABS 21
ETABS 22
Checklist: