Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Event aggregator #417

Draft
wants to merge 20 commits into
base: remove-dataflow
Choose a base branch
from
Draft

Conversation

adamhathcock
Copy link
Member

@adamhathcock adamhathcock commented Nov 28, 2024

Decouples exception handler from browser bridge.
IdleManager is now a OneTime event with IDs.
Rhino is converted.
Global Events (Doc changed) are converted.

More events to come!

Copy link

codecov bot commented Nov 28, 2024

Codecov Report

Attention: Patch coverage is 18.55204% with 180 lines in your changes missing coverage. Please review.

Project coverage is 8.71%. Comparing base (4b24584) to head (bda6abe).
Report is 10 commits behind head on remove-dataflow.

Files with missing lines Patch % Lines
...eckle.Connectors.DUI/Eventing/EventSubscription.cs 0.00% 34 Missing ⚠️
DUI3/Speckle.Connectors.DUI/Eventing/EventBase.cs 26.31% 28 Missing ⚠️
...UI3/Speckle.Connectors.DUI/Bridge/BrowserBridge.cs 0.00% 25 Missing ⚠️
...eckle.Connectors.DUI/Eventing/DelegateReference.cs 0.00% 23 Missing ⚠️
...UI3/Speckle.Connectors.DUI/Eventing/PubSubEvent.cs 5.00% 19 Missing ⚠️
...I3/Speckle.Connectors.DUI/Eventing/SpeckleEvent.cs 5.26% 18 Missing ⚠️
...eckle.Connectors.DUI/Eventing/SubscriptionToken.cs 0.00% 14 Missing ⚠️
....Connectors.DUI/Eventing/SpeckleEventAggregator.cs 0.00% 8 Missing ⚠️
...I3/Speckle.Connectors.DUI/ContainerRegistration.cs 0.00% 3 Missing ⚠️
...onnectors.DUI/Bindings/OperationProgressManager.cs 0.00% 2 Missing ⚠️
... and 4 more
Additional details and impacted files
@@                Coverage Diff                 @@
##           remove-dataflow    #417      +/-   ##
==================================================
- Coverage             9.07%   8.71%   -0.37%     
==================================================
  Files                  228     238      +10     
  Lines                 4340    4475     +135     
  Branches               522     558      +36     
==================================================
- Hits                   394     390       -4     
- Misses                3930    4070     +140     
+ Partials                16      15       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant