Fix(tekla): Read write model cards to/from appdata + fixes double UI #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #395 +/- ##
=====================================
Coverage ? 8.37%
=====================================
Files ? 237
Lines ? 4704
Branches ? 513
=====================================
Hits ? 394
Misses ? 4294
Partials ? 16 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
dogukankaratas
approved these changes
Nov 20, 2024
oguzhankoral
deleted the
oguzhan/cnx-583-readwrite-model-cards-to-document
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Double UI
A bit dancing with WPF and triggering
Closeexplicitly on unnecessary dialogs helped on not having weird UIs. We also have anotherIsInitializedstate that we make itfalseagain when the original UI is closed.Parenting the dialog
Connect handle of Plugin dialog to Tekla window which they work together now and our dialog is visible on top of Tekla!
Document change
We do not necessarily need to close dialogs, just watching document changed event (
ModelLoad) and trigger UI to refetch state after we read model state as explained below.Read/Write model cards
Seems like Tekla API is not friendly on saving things on file. I've introduced new way to handle it and it works as expected so far. @didimitrie was mentioning yesterday we might need similar logic for other connectors too.