Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(tekla): Attach parent applicationId to meshes #385

Merged
merged 2 commits into from
Nov 15, 2024
+6 −0
Merged

Fix(tekla): Attach parent applicationId to meshes #385

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
54808db
Attach parent applicationId to meshes
oguzhankoral Nov 15, 2024
687207d
Merge branch 'dev' into oguzhan/cnx-754-no-materials-colors
oguzhankoral Nov 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .../Tekla/Speckle.Converters.TeklaShared/ToSpeckle/TopLevel/ModelObjectToSpeckleConverter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,12 @@ public Base Convert(object target)
var displayValue = _displayValueExtractor.GetDisplayValue(modelObject).ToList();
if (displayValue.Count > 0)
{
foreach (var displayValueObject in displayValue)
{
// NOTE: since we put ModelObject applicationIds into proxies, we should also mutate the same application id for its displayValue objects.
// otherwise we will have anonymous objects on receive for other host apps
displayValueObject.applicationId = modelObject.GetSpeckleApplicationId();
}
result["displayValue"] = displayValue;
}

Expand Down