Use of obsolete members now generates warning #378
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that we had several obsolete warnings erroneously supressed
This caused a minor incident, where a function was made
Obsolete
in the SDK and we didn't realise we'd missed updating several connectors to use it.This PR re-enables those warnings about using obsolete members
Additionally, I've resolved several violations against host app API members that were made obsolete.
I'm willing to accept us supressing some of these warnings (like in the case of civil, where a member was marked obsolete in 2022, but then was no longer obsolete in 2023).
Host app APIs don't tend to be quite as dev friendly as we'd always like. But for the cases here where there genuine reason to update to avoid obsolete API functions, lets keep on top of it!