Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of obsolete members now generates warning #378

Merged
merged 3 commits into from
Nov 19, 2024

Conversation

JR-Morgan
Copy link
Member

@JR-Morgan JR-Morgan commented Nov 9, 2024

I noticed that we had several obsolete warnings erroneously supressed

This caused a minor incident, where a function was made Obsolete in the SDK and we didn't realise we'd missed updating several connectors to use it.


This PR re-enables those warnings about using obsolete members
Additionally, I've resolved several violations against host app API members that were made obsolete.

I'm willing to accept us supressing some of these warnings (like in the case of civil, where a member was marked obsolete in 2022, but then was no longer obsolete in 2023).
Host app APIs don't tend to be quite as dev friendly as we'd always like. But for the cases here where there genuine reason to update to avoid obsolete API functions, lets keep on top of it!

@JR-Morgan JR-Morgan requested a review from AlanRynne November 9, 2024 15:35
Copy link

codecov bot commented Nov 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 8.37%. Comparing base (774e24d) to head (df1eeb8).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@          Coverage Diff          @@
##             dev    #378   +/-   ##
=====================================
  Coverage   8.37%   8.37%           
=====================================
  Files        237     237           
  Lines       4704    4704           
  Branches     513     513           
=====================================
  Hits         394     394           
  Misses      4294    4294           
  Partials      16      16           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@JR-Morgan JR-Morgan requested a review from clairekuang November 9, 2024 16:06
@JR-Morgan JR-Morgan merged commit 13c2941 into dev Nov 19, 2024
5 checks passed
@JR-Morgan JR-Morgan deleted the jrm/fix-deprecated-usages branch November 19, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants