Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dimitrie/cnx 634 some elements are received as generic models ignoring #361

Conversation

didimitrie
Copy link
Member

Copy link

codecov bot commented Nov 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 29 lines in your changes missing coverage. Please review.

Project coverage is 8.40%. Comparing base (d5f1f76) to head (ba4cfca).
Report is 4 commits behind head on dev.

Files with missing lines Patch % Lines
...ckle/TopLevel/RailingTopLevelConverterToSpeckle.cs 0.00% 25 Missing ⚠️
.../ToHost/Raw/LocalToGlobalToDirectShapeConverter.cs 0.00% 2 Missing ⚠️
...verters.RevitShared/RevitRootToSpeckleConverter.cs 0.00% 1 Missing ⚠️
...ckle/TopLevel/ElementTopLevelConverterToSpeckle.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             dev    #361      +/-   ##
========================================
- Coverage   8.44%   8.40%   -0.05%     
========================================
  Files        237     238       +1     
  Lines       4663    4689      +26     
  Branches     514     514              
========================================
  Hits         394     394              
- Misses      4253    4279      +26     
  Partials      16      16              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@didimitrie didimitrie merged commit 5f4eebe into dev Nov 6, 2024
5 checks passed
@didimitrie didimitrie deleted the dimitrie/cnx-634-some-elements-are-received-as-generic-models-ignoring branch November 6, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants