unpack parameters as Dictionary #344
Draft
+46
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@KatKatKateryna they are sent under ‘properties’ not ‘parameters’ |
…tps://github.com/specklesystems/speckle-sharp-connectors into claire/cnx-687-purge-unused-classes-from-objects
…claire_classes_ArcGIS_parameters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #344 +/- ##
=====================================
Coverage 8.44% 8.44%
=====================================
Files 237 237
Lines 4663 4663
Branches 514 514
=====================================
Hits 394 394
Misses 4253 4253
Partials 16 16 ☔ View full report in Codecov by Sentry. |
Base automatically changed from
claire/cnx-687-purge-unused-classes-from-objects
to
dev
November 5, 2024 11:59
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unpacking parameters assuming they are Dictionary rather than a Base. Works with simple attributes, but Revit models seems to start sending null in "parameters" (e.g. https://latest.speckle.systems/projects/126cd4b7bb/models/523fc1299b ), need newer model to test