Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new sending is hooked up #338

Closed
wants to merge 22 commits into from

fix solution check

c80b05e
Select commit
Loading
Failed to load commit list.
Closed

new sending is hooked up #338

fix solution check
c80b05e
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 5, 2024 in 0s

8.50% (+0.09%) compared to 8cfe0bf

View this Pull Request on Codecov

8.50% (+0.09%) compared to 8cfe0bf

Details

Codecov Report

Attention: Patch coverage is 6.66667% with 56 lines in your changes missing coverage. Please review.

Project coverage is 8.50%. Comparing base (8cfe0bf) to head (c80b05e).

Files with missing lines Patch % Lines
...e.Connectors.Common/Operations/RootObjectSender.cs 0.00% 21 Missing ⚠️
...Speckle/TopLevel/RoomTopLevelConverterToSpeckle.cs 0.00% 13 Missing ⚠️
...e.Connectors.Common/Operations/ReceiveOperation.cs 0.00% 5 Missing ⚠️
.../TopLevel/DirectShapeTopLevelConverterToSpeckle.cs 0.00% 4 Missing ⚠️
...opLevel/FootPrintRoofToSpeckleTopLevelConverter.cs 0.00% 2 Missing ⚠️
...e/TopLevel/ModelCurveToSpeckleTopLevelConverter.cs 0.00% 2 Missing ⚠️
...RhinoShared/ToSpeckle/Raw/BoxToSpeckleConverter.cs 0.00% 2 Missing ⚠️
...itShared/ToHost/Raw/Geometry/ArcConverterToHost.cs 0.00% 1 Missing ⚠️
...e/Raw/Geometry/BoundingBoxXYZToSpeckleConverter.cs 0.00% 1 Missing ⚠️
...ToSpeckle/Raw/Geometry/CircleToSpeckleConverter.cs 0.00% 1 Missing ⚠️
... and 4 more
Additional details and impacted files 
@@           Coverage Diff            @@
##             dev    #338      +/-   ##
========================================
+ Coverage   8.40%   8.50%   +0.09%     
========================================
  Files        240     237       -3     
  Lines       4829    4632     -197     
  Branches     561     514      -47     
========================================
- Hits         406     394      -12     
+ Misses      4406    4222     -184     
+ Partials      17      16       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov