feat(rhino): adds names to all objects on bake #327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oguzhankoral
requested changes
Oct 25, 2024
| @@ -253,7 +256,7 @@ private void PreReceiveDeepClean(string baseLayerName) | |||
| _groupBaker.PurgeGroups(baseLayerName); | |||
| } | |||
|
|
|||
| private Guid BakeObject(GeometryBase obj, Base originalObject, int layerIndex) | |||
| private Guid BakeObject(GeometryBase obj, Base originalObject, int layerIndex, string? name = null) | |||
There was a problem hiding this comment.
since we already have originalObject in relevant functions, I wouldn't pollute function arguments. You need to do it only in BakeObjects function and thats it
There was a problem hiding this comment.
can't do it there, since originalObject could be a Base in a display value of an element that used fallback conversion for example. We need to do it in both the group converter and the bake then.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #327 +/- ##
========================================
- Coverage 8.40% 8.40% -0.01%
========================================
Files 240 240
Lines 4830 4832 +2
Branches 560 561 +1
========================================
Hits 406 406
- Misses 4407 4409 +2
Partials 17 17 ☔ View full report in Codecov by Sentry. |
oguzhankoral
approved these changes
Oct 25, 2024
clairekuang
deleted the
claire/cnx-688-rhino-add-name-of-objects-on-receive
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks for a
nameproperty on incoming atomic objects, and bakes rhino objects with a name if one exists.Motivation: while the name is nice to preserve for multiplayer flows, this property helps a lot when receiving fallback geometry from other apps (esp civil and revit) that would help identify what the original object was.
Also adds
nameproperty to all rhino objects on send.