Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(autocad): arc to host conversions fixed to remove dependency on incoming arc plane and angle props #325

Merged
merged 3 commits into from
Oct 24, 2024

Conversation

clairekuang
Copy link
Member

We were previously depending on the speckle arc's plane and start/end angle props to create autocad arcs. Since these props can't be guaranteed to be calculated "correctly" to autocad convention (eg when sent from civil), these dependencies have been removed and recalculated internally.

before:
image

result:
{5F794467-D0CD-49A8-AE7E-AFF716004C6B}

Copy link

linear bot commented Oct 24, 2024

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 8.40%. Comparing base (08bf19f) to head (7c01d0b).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@          Coverage Diff          @@
##             dev    #325   +/-   ##
=====================================
  Coverage   8.40%   8.40%           
=====================================
  Files        240     240           
  Lines       4830    4830           
  Branches     560     560           
=====================================
  Hits         406     406           
  Misses      4407    4407           
  Partials      17      17           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@clairekuang clairekuang requested a review from JR-Morgan October 24, 2024 16:12
@clairekuang clairekuang merged commit 900427a into dev Oct 24, 2024
5 checks passed
@clairekuang clairekuang deleted the claire/cnx-685-civil3d-autocad-arcs-received-rotated branch October 24, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants