fix(civil3d): alignment arc logic fixed #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #320 +/- ##
=====================================
Coverage 8.40% 8.40%
=====================================
Files 240 240
Lines 4816 4816
Branches 556 556
=====================================
Hits 405 405
Misses 4394 4394
Partials 17 17 ☔ View full report in Codecov by Sentry. |
AlanRynne
approved these changes
Oct 24, 2024
| @@ -22,37 +21,30 @@ IConverterSettingsStore<Civil3dConversionSettings> settingsStore | |||
|
|
|||
| public SOG.Arc Convert(CDB.AlignmentSubEntityArc target) | |||
| { | |||
| // alignment arcs do not have the same properties as autocad arcs. | |||
| // we're assuming they are always 2d arcs on the xy plane to calculate the midpoint | |||
There was a problem hiding this comment.
Is this assumption correct, or is there a chance a civil arc won't be laying on the 2d plane?
There was a problem hiding this comment.
They appear to always be of type Arc2d
clairekuang
deleted the
claire/cnx-673-arcs-look-flipped-in-the-viewer
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes flipped alignment arcs
sample commit:
https://latest.speckle.systems/projects/3f895e614f/models/fff1132068@56b5ffe759