Fix(revit): CNX-657 revit expiration checks seem to be not fully working for

[oguzhankoral]

TLDR; We still use UniqueIds.

Main problem was event of deleted objects. We were trying to get UniqueId by using provided ElementId, but doc.GetElement(elementId) can't get any element from deleted ElementId. We have to keep remember corresponding UniqueIds for ElementIds whenever they initially used.

[linear]

CNX-657 Revit: expiration checks seem to be not fully working for some elements

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 8.40%. Comparing base (613d45d) to head (acf5484).
Report is 1 commits behind head on dev.

Additional details and impacted files

@@          Coverage Diff          @@
##             dev    #316   +/-   ##
=====================================
  Coverage   8.40%   8.40%           
=====================================
  Files        240     240           
  Lines       4816    4816           
  Branches     556     556           
=====================================
  Hits         405     405           
  Misses      4394    4394           
  Partials      17      17           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[clairekuang]

Only comment: we should check for selection filter behavior when a user deletes a saved object without updating the filter before sending.