Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(civil3d): uses preprocessor error instead of throwing exception for unsupported versions #314

Closed
wants to merge 11 commits into from
Closed

chore(civil3d): uses preprocessor error instead of throwing exception for unsupported versions #314

Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
4afa5eb
adds 2022,2023,and 2025 versions for civil3d
clairekuang Oct 17, 2024
c003ce5
removes unnecessary assembly info
clairekuang Oct 17, 2024
08c8b2f
fixes version api issues
clairekuang Oct 17, 2024
9178532
fixes more version api issues
clairekuang Oct 17, 2024
a1b0fad
Update CivilEntityToSpeckleTopLevelConverter.cs
clairekuang Oct 17, 2024
57e1bfc
more fixes
clairekuang Oct 18, 2024
f09ff72
updates local
clairekuang Oct 18, 2024
9e0e671
Merge branch 'dev' into claire/cnx-622-add-civil3d-2022-2023-and-2025…
clairekuang Oct 18, 2024
e96f1f5
Merge branch 'dev' into claire/cnx-622-add-civil3d-2022-2023-and-2025…
clairekuang Oct 21, 2024
6e2a5e6
Update AppUtils.cs
clairekuang Oct 21, 2024
da98ae2
Merge branch 'dev' into claire/cnx-622-add-civil3d-2022-2023-and-2025…
clairekuang Oct 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions Connectors/Autocad/Speckle.Connectors.AutocadShared/Plugin/AppUtils.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@
HostAppVersion.v2023;
#elif AUTOCAD2022 || CIVIL3D2022
HostAppVersion.v2022;
#else
throw new NotSupportedException();
#error host application not supported

Check failure on line 25 in Connectors/Autocad/Speckle.Connectors.AutocadShared/Plugin/AppUtils.cs

View workflow job for this annotation

GitHub Actions / build 

#error: 'host application not supported'

Check failure on line 25 in Connectors/Autocad/Speckle.Connectors.AutocadShared/Plugin/AppUtils.cs

View workflow job for this annotation

GitHub Actions / build 

#error: 'host application not supported'

Check failure on line 25 in Connectors/Autocad/Speckle.Connectors.AutocadShared/Plugin/AppUtils.cs

View workflow job for this annotation

GitHub Actions / build 

#error: 'host application not supported'

Check failure on line 25 in Connectors/Autocad/Speckle.Connectors.AutocadShared/Plugin/AppUtils.cs

View workflow job for this annotation

GitHub Actions / build 

#error: 'host application not supported'
#endif
}
Loading