feat(civil3d): adds 2022, 2023, and 2025 versions #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #306 +/- ##
=====================================
Coverage 8.40% 8.40%
=====================================
Files 240 240
Lines 4816 4816
Branches 556 556
=====================================
Hits 405 405
Misses 4394 4394
Partials 17 17 ☔ View full report in Codecov by Sentry. |
JR-Morgan
reviewed
Oct 18, 2024
| @@ -10,21 +10,19 @@ public static class AppUtils | |||
| #elif AUTOCAD | |||
| HostApplications.AutoCAD; | |||
| #else | |||
| throw new NotImplementedException(); | |||
| throw new NotSupportedException(); | |||
There was a problem hiding this comment.
Just a comment,
I think we could use the preprocessor error
#error host application not supported
instead, it might give us quicker feedback when we come to add a new project verison
AlanRynne
approved these changes
Oct 21, 2024
adamhathcock
approved these changes
Oct 21, 2024
clairekuang
deleted the
claire/cnx-622-add-civil3d-2022-2023-and-2025-support
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds additional versions for civil3d