ArcGIS GroupLayers #293
Merged
ArcGIS GroupLayers #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #293 +/- ##
=====================================
Coverage 8.62% 8.62%
=====================================
Files 231 231
Lines 4635 4635
Branches 542 542
=====================================
Hits 400 400
Misses 4218 4218
Partials 17 17 ☔ View full report in Codecov by Sentry. |
AlanRynne
approved these changes
Oct 10, 2024
Comment on lines
+319
to
+322
| if (rowCursor is null) | ||
| { | ||
| return; | ||
| } |
There was a problem hiding this comment.
Does this mean that we can skip an item in a layer if it's null?
Could this happen for a valid layer with valid fields?
Maybe I'm understanding this wrong 😅 but if this is the case we should at least log it somehow.
There was a problem hiding this comment.
added a comment 🙌
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Treat all Collection-alike layers as GroupLayers (converting to Collections). Otherwise, they are passed to the Converter and justifiably failing.