Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to pass log info to serilog without rendering the log statement #266

Conversation

adamhathcock
Copy link
Member

No description provided.

Copy link

linear bot commented Sep 23, 2024

Copy link

codecov bot commented Sep 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 8.43%. Comparing base (b086d16) to head (537731c).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
Sdk/Speckle.Connectors.Common/SpeckleLogger.cs 0.00% 6 Missing ⚠️
...dk/Speckle.Connectors.Common/SpeckleLogProvider.cs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##             dev    #266   +/-   ##
=====================================
  Coverage   8.43%   8.43%           
=====================================
  Files        231     231           
  Lines       4567    4567           
  Branches     562     562           
=====================================
  Hits         385     385           
  Misses      4165    4165           
  Partials      17      17           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adamhathcock adamhathcock marked this pull request as ready for review September 24, 2024 13:24
@adamhathcock adamhathcock enabled auto-merge (squash) September 26, 2024 10:31
@adamhathcock adamhathcock merged commit 6115620 into dev Sep 26, 2024
5 checks passed
@adamhathcock adamhathcock deleted the adam/cxpla-82-v3-logs-are-rendered-strings-not-templated-messages branch September 26, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants