ArcGIS GeodatabaseTableException #264
Open
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JR-Morgan
commented
Sep 20, 2024
| @@ -44,7 +44,7 @@ public void ClearExistingDataset(string featureClassName) | |||
| schemaBuilder.Build(); | |||
| MapView.Active.Redraw(true); | |||
| } | |||
| catch (Exception ex) when (!ex.IsFatal()) //(GeodatabaseTableException) | |||
| catch (GeodatabaseTableException ex) | |||
| { | |||
| // "The table was not found." | System.InvalidCast | |||
There was a problem hiding this comment.
should this also be handling System.InvalidCastException?
There was a problem hiding this comment.
looks legit with your changes already, we don't seems to cast anything here, no?
There was a problem hiding this comment.
Doesn't look to be. But there was this comment so I thought I'd ask.
Perhaps GetDefinition<FeatureClassDefinition> may throw if there is something in the db with the name, but it isn't a FeatureClassDefinition
Not sure if that's even a possibility.
auto-merge was automatically disabled
September 20, 2024 10:54
Pull request was closed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #264 +/- ##
=====================================
Coverage 7.86% 7.86%
=====================================
Files 235 235
Lines 4477 4477
Branches 523 523
=====================================
Hits 352 352
Misses 4110 4110
Partials 15 15 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Where possible, we should be specific about the exceptions we intend to handle