Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore(revit): Refactor material cache to ToHost ToSpeckle singletons #262

Merged
merged 6 commits into from
Sep 25, 2024
+165 −137

Remove old notes

6ab98c5
Select commit
Loading
Failed to load commit list.
Merged

Chore(revit): Refactor material cache to ToHost ToSpeckle singletons #262

Remove old notes
6ab98c5
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 25, 2024 in 0s

8.46% (-0.01%) compared to d8f3fa7

View this Pull Request on Codecov

8.46% (-0.01%) compared to d8f3fa7

Details

Codecov Report

Attention: Patch coverage is 0% with 64 lines in your changes missing coverage. Please review.

Project coverage is 8.46%. Comparing base (d8f3fa7) to head (6ab98c5).

Files with missing lines Patch % Lines
.../Raw/MaterialAsRevitMaterialConversionToSpeckle.cs 0.00% 23 Missing ⚠️
...aw/MaterialAsSpeckleMaterialConversionToSpeckle.cs 0.00% 22 Missing ⚠️
.../Raw/Geometry/MeshByMaterialDictionaryToSpeckle.cs 0.00% 6 Missing ⚠️
...hared/ToSpeckle/Raw/MaterialQuantitiesToSpeckle.cs 0.00% 4 Missing ⚠️
...evitShared/Helpers/RevitToSpeckleCacheSingleton.cs 0.00% 3 Missing ⚠️
...tShared/ToHost/Raw/Geometry/MeshConverterToHost.cs 0.00% 3 Missing ⚠️
...ckle.Converters.RevitShared/ServiceRegistration.cs 0.00% 2 Missing ⚠️
...s.RevitShared/Helpers/RevitToHostCacheSingleton.cs 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff            @@
##             dev    #262      +/-   ##
========================================
- Coverage   8.46%   8.46%   -0.01%     
========================================
  Files        229     231       +2     
  Lines       4546    4548       +2     
  Branches     553     550       -3     
========================================
  Hits         385     385              
- Misses      4144    4146       +2     
  Partials      17      17

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov