Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(autocad): TryGetMaterialId for both cases #259

Merged

Conversation

oguzhankoral
Copy link
Member

We check now first original atomic object and then its parent base if provided.

Regression:
Fixing one problem on rhino receive materials caused another problem on revit receive render materials.
Because different behaviors on apps

  • rhino: Brep (material id is extracted into render material proxy objects) -> [Mesh, Mesh, ...] (child objects application ids ARE NOT EXIST in render material proxy objects)
  • revit : RevitElement (material IS NOT extracted into render material proxy objects) -> [Mesh, Mesh...] (child objects application ids EXIST in render material proxy objects)

BEFORE

acad_8fEz2qpdpc

AFTER

acad_KZcMP4UTUq

Copy link

linear bot commented Sep 19, 2024

Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 7.81%. Comparing base (50414e9) to head (b164709).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@          Coverage Diff          @@
##             dev    #259   +/-   ##
=====================================
  Coverage   7.81%   7.81%           
=====================================
  Files        236     236           
  Lines       4518    4518           
  Branches     543     543           
=====================================
  Hits         353     353           
  Misses      4149    4149           
  Partials      16      16           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oguzhankoral oguzhankoral enabled auto-merge (squash) September 23, 2024 16:53
@oguzhankoral oguzhankoral merged commit fd992d6 into dev Sep 23, 2024
5 checks passed
@oguzhankoral oguzhankoral deleted the oguzhan/cnx-517-autocad-revit-render-materials-are-missing branch September 23, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants