Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(rhino): missing render material of layers on second send #252

Merged

Conversation

oguzhankoral
Copy link
Member

When creating a layer on receive we cannot set RenderMaterial to layer. (RhinoCommon API limitation, it tested)
We can only set render material index of layer on receive. So for the second send, we also need to check its index!

BEFORE (see 2 render material proxies on scene explorer)

chrome_t4P4Eia37c

AFTER (see 6 render material proxies on scene explorer)

chrome_KSn5V2ppZb

Copy link

linear bot commented Sep 18, 2024

Copy link

codecov bot commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 7.38%. Comparing base (4a2233e) to head (07a909f).

Additional details and impacted files
@@          Coverage Diff          @@
##             dev    #252   +/-   ##
=====================================
  Coverage   7.38%   7.38%           
=====================================
  Files        243     243           
  Lines       4767    4767           
  Branches     564     564           
=====================================
  Hits         352     352           
  Misses      4400    4400           
  Partials      15      15           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oguzhankoral oguzhankoral merged commit 2418b3e into dev Sep 18, 2024
5 checks passed
@oguzhankoral oguzhankoral deleted the oguzhan/cnx-468-rhino-layer-material-doesnt-show-up-viewer branch September 18, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants