Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(autocad): Pass parent base object instead base under displayValues to find material #249

Merged

Conversation

oguzhankoral
Copy link
Member

We were passing base object under displayValue which was lacking applicationId. Instead I pass Brep object as base into BakeObjectsAsGroup function.

https://latest.speckle.systems/projects/126cd4b7bb/models/f3b0250890

BEFORE

acad_IAghjmNXXa

AFTER

acad_tG2736MrEK

Copy link

linear bot commented Sep 18, 2024

@oguzhankoral oguzhankoral changed the title Fix(autocad): Pass base object not mesh under displayValues Fix(autocad): Pass parent base object instead base under displayValues to find material Sep 18, 2024
@oguzhankoral oguzhankoral merged commit b52d66c into dev Sep 18, 2024
3 checks passed
@oguzhankoral oguzhankoral deleted the oguzhan/cnx-440-autocad-render-materials-receive-doesnt-work branch September 18, 2024 11:57
Copy link

codecov bot commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (dev@3454587). Learn more about missing BASE report.
Report is 1 commits behind head on dev.

Additional details and impacted files
@@          Coverage Diff          @@
##             dev    #249   +/-   ##
=====================================
  Coverage       ?   7.51%           
=====================================
  Files          ?     241           
  Lines          ?    4684           
  Branches       ?     548           
=====================================
  Hits           ?     352           
  Misses         ?    4317           
  Partials       ?      15           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants